lsp: Revert URL type change #13193
Merged
lsp: Revert URL type change #13193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
|
@osiewicz May I ask you share your experience in gluon-lang/lsp-types#284 so that people who try to migrate to the newer version of lsp-types have more information about the problems you encountered. |
|
I don't think I have anything to add on that matter, sorry. I think upvoting the issue and referencing it in my PR should be sufficient, as bumping it is unlikely to push it forward any further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts URI changes made in #12928 while keeping the perf goodies in tact. We should keep an eye out for gluon-lang/lsp-types#284
Fixes: #13135
Fixes: #13131
Release Notes: